Tidy-up to merge with 17: Change 'error' to 'r' in dm_suspend. --- diff/drivers/md/dm.c 2005-07-06 18:58:39.000000000 +0100 +++ source/drivers/md/dm.c 2005-07-06 18:58:35.000000000 +0100 @@ -1044,7 +1044,7 @@ { struct dm_table *map; DECLARE_WAITQUEUE(wait, current); - int error = -EINVAL; + int r = -EINVAL; /* Flush I/O to the device. */ down_read(&md->lock); @@ -1055,8 +1055,8 @@ /* This does not get reverted if there's an error later. */ dm_table_presuspend_targets(map); - error = __lock_fs(md); - if (error) { + r = __lock_fs(md); + if (r) { dm_table_put(map); goto out_read_unlock; } @@ -1069,7 +1069,7 @@ * If the flag is already set we know another thread is trying to * suspend as well, so we leave the fs locked for this thread. */ - error = -EINVAL; + r = -EINVAL; down_write(&md->lock); if (test_and_set_bit(DMF_BLOCK_IO, &md->flags)) { if (map) @@ -1104,7 +1104,7 @@ remove_wait_queue(&md->wait, &wait); /* were we interrupted ? */ - error = -EINTR; + r = -EINTR; if (atomic_read(&md->pending)) goto out_unfreeze; @@ -1122,11 +1122,11 @@ clear_bit(DMF_BLOCK_IO, &md->flags); out_write_unlock: up_write(&md->lock); - return error; + return r; out_read_unlock: up_read(&md->lock); - return error; + return r; } int dm_resume(struct mapped_device *md)