The dm emc hardware handler code memset the hardware handler structure to zero AFTER it had initialized the structure's spinlock field. Signed-Off-By: Alasdair G Kergon From: Dave Olien --- diff/drivers/md/dm-emc.c 2005-04-21 18:48:40.000000000 +0100 +++ source/drivers/md/dm-emc.c 2005-04-21 18:48:29.000000000 +0100 @@ -223,8 +223,10 @@ { struct emc_handler *h = kmalloc(sizeof(*h), GFP_KERNEL); - if (h) + if (h) { + memset(h, 0, sizeof(*h)); spin_lock_init(&h->lock); + } return h; } @@ -259,8 +261,6 @@ if (!h) return -ENOMEM; - memset(h, 0, sizeof(*h)); - hwh->context = h; if ((h->short_trespass = short_trespass))